feat(machines): add data-required
for field labels
#2673
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds the
data-required
attribute to form field labels when therequired
prop is set totrue
. This enhancement provides better accessibility and styling capabilities for required form fields across all Zag form components.This change was inspired by commit 011741e from Ark UI, ensuring consistency between the two libraries.
⛳️ Current behavior (updates)
Form field labels do not include any indication when a field is required, making it difficult for developers to consistently style required fields and provide proper accessibility indicators.
🚀 New behavior
All form field labels now include the
data-required
attribute when therequired
prop istrue
, providing consistent styling hooks and accessibility improvements across all form components. Only form components that already had arequired
property defined in their types were modified, ensuring backward compatibility and maintaining the existing API surface.💣 Is this a breaking change (Yes/No):
No.
📝 Additional Information
This enhancement significantly improves the developer experience by providing a standardized, framework-agnostic way to style required form fields without the need for custom logic or manual attribute management, making it easier to create consistent and accessible user interfaces.