Skip to content

fix(532): fontFamily get on css rules #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(532): fontFamily get on css rules #547

wants to merge 1 commit into from

Conversation

jpinsonneau
Copy link

Fixes #532

Description

fontFamily may not be accessible on rules directly (seen that on Firefox).
Relying on getPropertyValue ensure it's properly parsed on every browser.

Motivation and Context

Currently crashing:

oops, something went wrong! TypeError: can't access property "trim", t is undefined

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@biiibooo
Copy link
Contributor

biiibooo bot commented Jul 16, 2025

👋 @jpinsonneau

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov Codecov
Copy link

codecov bot commented Jul 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.50%. Comparing base (d9b2fcf) to head (27ccfff).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/embed-webfonts.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #547   +/-   ##
=======================================
  Coverage   66.50%   66.50%           
=======================================
  Files          10       10           
  Lines         612      612           
  Branches      150      150           
=======================================
  Hits          407      407           
  Misses        144      144           
  Partials       61       61

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jpinsonneau jpinsonneau mentioned this pull request Jul 16, 2025
Open
@vincerubinetti
Copy link

Testing this locally, it seems like this fixes #508 too

@vincerubinetti vincerubinetti mentioned this pull request Jul 17, 2025
Closed
@jo-chemla jo-chemla mentioned this pull request Jul 22, 2025
Closed
3 tasks
@galliotl galliotl mentioned this pull request Aug 7, 2025
Open
15 tasks
@david-rud
Copy link

david-rud commented Aug 20, 2025 •
edited
Loading

@jpinsonneau @vincerubinetti @galliotl @QuentiumYT @GordonSmith @bubkoo can this please be escalated and merged? Our functionality doesn't work in Firefox PROD because of this.

@QuentiumYT
Copy link

QuentiumYT commented Aug 20, 2025 •
edited
Loading

@jpinsonneau @vincerubinetti @galliotl @QuentiumYT @GordonSmith @bubkoo can this please be escalated and merged? Our functionality doesn't work in Firefox PROD because of this.

We cannot do anything, only @bubkoo can merge but he seems away for 6 months now

@jpinsonneau
Copy link
Author

Build your own npm package from that PR or use mine: https://www.npmjs.com/package/@jpinsonneau/html-to-image

@SuperJakov
Copy link

I think we as a community, should create a new. maintained package. I will try to make it and add all of community's bug fixes...

@SuperJakov SuperJakov mentioned this pull request Aug 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@galliotl galliotl galliotl approved these changes

@QuentiumYT QuentiumYT QuentiumYT approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firefox: TypeError: can't access property "trim", t is undefined
6 participants
@jpinsonneau @vincerubinetti @david-rud @QuentiumYT @SuperJakov @galliotl