Skip to content

Fix websocket permessage-deflate error on partial message consumption #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix websocket permessage-deflate error on partial message consumption #3029

wants to merge 2 commits into from
+1,433 −59,116

Conversation

ashtum
Copy link
Collaborator

@ashtum ashtum commented Sep 2, 2025

fixes #3028

@ashtum ashtum force-pushed the fix-websocket-pmd-partial-consumption branch 8 times, most recently from 6c6b94e to 0a4d671 Compare September 3, 2025 12:11
@codecov Codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.16%. Comparing base (9b24b28) to head (0a4d671).

Files with missing lines Patch % Lines
include/boost/beast/websocket/detail/impl_base.hpp 83.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3029      +/-   ##
===========================================
+ Coverage    93.09%   93.16%   +0.07%     
===========================================
  Files          176      176              
  Lines        13647    13655       +8     
===========================================
+ Hits         12704    12722      +18     
+ Misses         943      933      -10
Files with missing lines Coverage Δ
include/boost/beast/websocket/impl/read.hpp 95.26% <100.00%> (+0.59%) ⬆️
include/boost/beast/websocket/detail/impl_base.hpp 86.25% <83.33%> (-0.18%) ⬇️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b24b28...0a4d671. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ashtum ashtum force-pushed the fix-websocket-pmd-partial-consumption branch from 0a4d671 to a60b4da Compare September 3, 2025 17:28
@ashtum ashtum force-pushed the fix-websocket-pmd-partial-consumption branch from a60b4da to 0dfb034 Compare September 3, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible bug in permessage_deflate handling: invalid stored block length on async_read
1 participant
@ashtum