-
Notifications
You must be signed in to change notification settings - Fork 221
Add build preview trigger #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have concerns about the added step required for this preview. I believe GitHub Actions can be configured to run on PRs from new contributors across different repositories without this workaround.
Could you please investigate alternative implementation approaches, such as using a GitHub App? Let's confirm if this extra step is the only way to achieve the desired preview functionality.
I think I misinterpreted it in my comment "So this PR triggers the pull_request_target when an admin or collaborator has /build-preview in their comment". here is what happens with this new workflow
![]()
An example for you to see is in bitcointranscripts/demo-test-transcript#2 in this case i only approved the workflow to run and no build-preview comment In this other example bitcointranscripts/demo-test-transcript#1 I had to comment /build-preview because the earlier workflow failed. So in conclusion it is not really an extra step. |
Thanks for clarifying @0tuedon! I have two follow-up questions:
![]() |
An Example again is this bitcointranscripts/demo-test-transcript#2, I merged this bitcointranscripts/demo-test-transcript#1 and @jrakibi is no longer a first time contributor and no approval was needed for the updates. |
Got it, thanks for clarifying! One last question: is there a reason to keep the |
I agree with you, my reason for adding it was because i did think the comment was needed to trigger a rebuild and it was needed to grant access to the secrets. I will remove the if conditon and also test on the https://github.com/bitcointranscripts/demo-test-transcript repo |
df580af
to
0d14412
Compare
Hi @kouloumos, I have updated the requirements, please help review. |
From this comment it turns out our current setup from PR #590 doesn't work for fork PR, the reason might be because fork PRs don't directly have access to secrets here.
So this PR triggers the
pull_request_target
when an admin or collaborator has/build-preview
in their comment, this will give access to the secrets when the workflow runsI also had a test here 0tuedon#2