Add the-great-consensus-cleanup-revival review to bitcoin-explained #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnado Cash and Samourai Wallet Arrests)" transcript submitted by mvuk
…rnado Cash and Samourai Wallet Arrests)" transcript submitted by mvuk
…rnado Cash and Samourai Wallet Arrests)" transcript submitted by mvuk
…rnado Cash and Samourai Wallet Arrests)" transcript submitted by mvuk
realdezzy
reviewed
Oct 7, 2024
| That's annoying because that check as we said is slow, so the proposal here is to do something else that makes sure that this duplication cannot happen. | ||
| So not just putting the height in the Coinbase but also putting something else in it. | ||
| What that something else is we don't know. | ||
| My favorite is to make SegWit mandatory as in the SegWit commitment because every SegWit block has an OP return and followed by the hash of the witness data. | ||
| My favorite is to make SegWit mandatory as in the SegWit commitment because every SegWit block has an OP_RETURN and followed by the hash of the witness data. |
There was a problem hiding this comment.
Please remember to enclose opcodes, such as 'OP_RETURN', in backticks (``).
realdezzy
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Hey! @mvuk
Thank you for your contribution! You did a great job on this review.
I’ve made a few minor corrections for clarity and flow, but overall your work was well done. Please take a look at the changes for future reference. Once these adjustments are addressed, we’ll be ready to merge.
Keep up the great work, and I look forward to seeing more reviews from you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the-great-consensus-cleanup-revival transcript review to the bitcoin-explained directory.