Skip to content

Dynamic export options #9271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dynamic export options #9271

wants to merge 2 commits into from

Conversation

grliszas14
Copy link
Contributor

@grliszas14 grliszas14 commented Aug 29, 2025 •
edited
Loading

Resolves: #9207
Resolves: #9232
Resolves: #9205

  • I signed CLA
  • The title of the pull request describes an issue it addresses
  • If changes are extensive, then there is a sequence of easily reviewable commits
  • Each commit's message describes its purpose and effects
  • There are no behavior changes unnecessary for the stated purpose of the PR

Recommended:

  • Each commit compiles and runs on my machine without known undesirable changes of behavior

@grliszas14 grliszas14 force-pushed the dynamic_export_options branch from d7f233b to 6351a4c Compare August 29, 2025 07:57
@grliszas14 grliszas14 marked this pull request as ready for review August 29, 2025 07:58
@grliszas14 grliszas14 force-pushed the dynamic_export_options branch from 6351a4c to 18b116a Compare September 1, 2025 07:59
@grliszas14 grliszas14 force-pushed the dynamic_export_options branch from 18b116a to 2019200 Compare September 2, 2025 08:14
saintmatthieu
saintmatthieu reviewed Sep 3, 2025
View reviewed changes
src/importexport/export/internal/au3/au3exporter.cpp

int Au3Exporter::optionsCount() const
{
std::string format = exportConfiguration()->currentFormat();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there could be a helper, OptionsEditorPtr optionsEditor() const , right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintmatthieu saintmatthieu saintmatthieu left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@grliszas14 @saintmatthieu