Qt 6.9 #9255
Qt 6.9 #9255
Conversation
8cfccd5 to
33b0453
Compare
| - name: Install Qt | ||
| uses: jurplel/install-qt-action@v4 | ||
| with: | ||
| version: '6.9.1' |
There was a problem hiding this comment.
6.9.2 has been released this week, so you might want to start with that version immediately
| @@ -20,6 +20,8 @@ set(MODULE_TEST_LINK | |||
|
|
|||
| muse::uicomponents | |||
| muse::ui | |||
|
|
|||
| Qt::Quick | |||
There was a problem hiding this comment.
Is it playback_tests that needs to link to Qt::Quick, or is it playback?
(Also, at MU, everything links to global, and global publicly links to Qt::Quick because of PCH. So at MU, something like this is not necessary.)
There was a problem hiding this comment.
That was my first thought.
timecodemodel_tests.cpp includes timecode.h which includes QQuickItem, so it is a test.
Adding all generic modules to global makes sense. How does it affect compile time?
There was a problem hiding this comment.
How does it affect compile time?
Hm, I haven't investigated that, sorry
| @@ -70,9 +70,6 @@ Item { | |||
|
|
|||
| model: toolBarModel | |||
|
|
|||
| width: contentItem.childrenRect.width | |||
| height: contentItem.childrenRect.height | |||
There was a problem hiding this comment.
If you ever encounter similar issues elsewhere, where just removing these lines doesn't help, see also here: musescore/MuseScore#24326 (a community member figured it out for us)
9859e20 to
80de184
Compare
Fixes flickering when clip is moved
…ng ... or the statement `effectState: root.item ? root.item.effectState() : null` complained that `null` could not be assigned to ` RealtimeEffectStatePtr`.
Some VSTs were overdrawing QML UI elements, causing them to render as black.
| //! NOTE: For unknown reasons, Linux scaling for 1 is defined as 1.003 in fractional scaling. | ||
| //! Because of this, some elements are drawn with a shift on the score. | ||
| //! Let's make a Linux hack and round values above 0.75(see RoundPreferFloor) | ||
| #ifdef Q_OS_LINUX | ||
| QGuiApplication::setHighDpiScaleFactorRoundingPolicy(Qt::HighDpiScaleFactorRoundingPolicy::RoundPreferFloor); | ||
| #elif defined(Q_OS_WIN) | ||
| QGuiApplication::setHighDpiScaleFactorRoundingPolicy(Qt::HighDpiScaleFactorRoundingPolicy::PassThrough); | ||
| #endif |
There was a problem hiding this comment.
This code was removed from MU in musescore/MuseScore@0728fc7 and musescore/MuseScore@dc5341c
| host: 'mac' | ||
| target: 'desktop' | ||
| arch: 'clang_64' | ||
| modules: 'qt5compat qtnetworkauth qtscxml qtshadertools qtwebsockets' |
There was a problem hiding this comment.
You might want to check if qtscxml is necessary for Audacity. In MU, it's only needed because one legacy widget uses Qt StateMachine, and therefore I doubt Audacity needs it.
Update Qt to 6.9
Recommended: