Fundamentally improve German translations #3780
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring translations closer to the English original, also removing some extraneous information. Get rid of all warnings poedit displayed. Correct translation that didn't match at all.
xgettext was not recognizing tr() invocations. Following https://stackoverflow.com/a/11901925 fixed the issue
Improve consistency with some translations. Add translations for messages that were just detected in the previous commit. Add translations for Graphics Drivers
Look for untranslated strings in the source files and add make them recognized by gettext
5930dc3 to
499652f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
poedit and archinstall now report 100% translation rate for German. I added tr() invocations in some places and adjusted the locale generation script to properly detect them (I didn't work for me before).
Tests and Checks
But there's a problem: Some translations are not picked up, for example "No audio server". I didn't figure out why, did I overlook something obvious? I ran the locale generation script before committing and the .mo file was changed.
Some translations also had a different amount of {}. I don't know if I broke something without noticing.
Should I regenerate all languages because the .pot changed?