Skip to content

Conversation

rafaelsmf
Copy link
Contributor

No description provided.

@rafaelsmf rafaelsmf changed the title chore(docs): fix typos and enhance doc for better readability [docs] Fix typos and enhance doc for better readability Aug 20, 2025
Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rafaelsmf, thanks for your contribution!

I noticed the main change in this PR is renaming Engine Flink to Flink Engine. While we appreciate the suggestion, the current naming (Engine Flink) is intentional.

As we're expanding support to other engines like Spark and Trino, using a consistent prefix — such as Engine Flink, Engine Spark, Engine Trino — helps keep the naming structure uniform and more organized across the project.

Let’s keep it as Engine Flink for now to maintain consistency. Thanks again for your input!

@rafaelsmf
Copy link
Contributor Author

Hi @rafaelsmf, thanks for your contribution!

I noticed the main change in this PR is renaming Engine Flink to Flink Engine. While we appreciate the suggestion, the current naming (Engine Flink) is intentional.

As we're expanding support to other engines like Spark and Trino, using a consistent prefix — such as Engine Flink, Engine Spark, Engine Trino — helps keep the naming structure uniform and more organized across the project.

Let’s keep it as Engine Flink for now to maintain consistency. Thanks again for your input!

Hi @wuchong ,

Thanks for the review. I now understand the structure of the Flink engine section and have reverted the proposed rename. I also fixed several typos and improved parts of the doc for readability.

Additionally, I updated the URL from Alibaba to Apache as suggested.

@rafaelsmf rafaelsmf requested a review from wuchong August 24, 2025 18:08
@polyzos polyzos force-pushed the main branch 3 times, most recently from d88c76c to 434a4f4 Compare August 31, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants