Skip to content

Fix migration script with revisionID 29ce7909c52b #54242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix migration script with revisionID 29ce7909c52b #54242

wants to merge 1 commit into from

Conversation

MASTREX
Copy link

@MASTREX MASTREX commented Aug 7, 2025 •
edited by eladkal
Loading

closes: #54071

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@MASTREX MASTREX requested a review from ephraimbuddy as a code owner August 7, 2025 18:18
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Aug 7, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added the area:db-migrations PRs with DB migration label Aug 7, 2025
@MASTREX
Copy link
Author

MASTREX commented Aug 7, 2025

the backup column task_instance_id_backup can be deleted later when doing further upgrade like from v3.0.0 to v3.0.1
But I was not sure which specific file to put the deletion code

@eladkal eladkal added this to the Airflow 3.0.5 milestone Aug 8, 2025
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Aug 8, 2025
@eladkal eladkal requested review from ashb and kaxil August 12, 2025 10:31
@kaxil kaxil modified the milestones: Airflow 3.0.5, Airflow 3.0.6 Aug 13, 2025
@kaxil kaxil modified the milestones: Airflow 3.0.6, Airflow 3.0.7 Aug 21, 2025
ephraimbuddy
ephraimbuddy reviewed Sep 1, 2025
View reviewed changes
airflow-core/src/airflow/migrations/versions/0068_3_0_0_ti_table_id_unique_per_try.py
"task_instance_id_backup",
new_column_name="task_instance_id",
existing_type=_get_uuid_type(dialect_name),
existing_nullable=False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about new TIs created after you did the backup? task_instance_id for those columns on TI history would be null

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What my understanding is it would be copied from the backup column task_instance_id_backup so it shouldn't be null

Can you also look at #54071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephraimbuddy ephraimbuddy ephraimbuddy left review comments

@ashb ashb Awaiting requested review from ashb

@kaxil kaxil Awaiting requested review from kaxil

@dstandish dstandish Awaiting requested review from dstandish

@vatsrahul1001 vatsrahul1001 Awaiting requested review from vatsrahul1001

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:db-migrations PRs with DB migration type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 3.0.7
Development

Successfully merging this pull request may close these issues.

Failure while downgrading from v3.0.0 to v2.x.x (Revision ID: 29ce7909c52b)
4 participants
@MASTREX @ephraimbuddy @kaxil @eladkal