Skip to content

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Sep 5, 2025

Ensure that each public API symbol in @angular/forms/signals is marked
as @experimental, also ensure that all public APIs live under api/.

@mmalerba mmalerba requested review from leonsenft and kirjs September 5, 2025 21:04
@ngbot ngbot bot modified the milestone: Backlog Sep 5, 2025
@pullapprove pullapprove bot requested a review from JeanMeche September 5, 2025 21:05
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from atscott September 5, 2025 21:09
Copy link

github-actions bot commented Sep 5, 2025

Deployed adev-preview for d8dc6f6 to: https://ng-dev-previews-fw--pr-angular-angular-63616-adev-prev-0sbvc9av.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Ensure that each public API symbol in @angular/forms/signals is marked
as `@experimental`
Moves the control directive under api/ since it is part of the public
API. Also removes the interop abstract control from the public API
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Sep 5, 2025
Add `validateStandardSchema` which was accidentally omitted from the
public api.
@mmalerba mmalerba added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 7, 2025
@mmalerba
Copy link
Contributor Author

mmalerba commented Sep 7, 2025

caretaker note: requires g3 patch update: cl/804127158

Copy link
Contributor

@NothingEverHappens NothingEverHappens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

Copy link
Contributor

@kirjs kirjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Sep 8, 2025
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

@atscott
Copy link
Contributor

atscott commented Sep 8, 2025

This PR was merged into the repository by commit 00a1806.

The changes were merged into the following branches: main

@atscott atscott closed this in 6d3f654 Sep 8, 2025
atscott pushed a commit that referenced this pull request Sep 8, 2025
Moves the control directive under api/ since it is part of the public
API. Also removes the interop abstract control from the public API

PR Close #63616
atscott pushed a commit that referenced this pull request Sep 8, 2025
Add `validateStandardSchema` which was accidentally omitted from the
public api.

PR Close #63616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: forms merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants