Skip to content

Fix handling of directory paths containing spaces in setup.sh #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix handling of directory paths containing spaces in setup.sh #142

wants to merge 1 commit into from

Conversation

m1kethai
Copy link

Fixed an issue causing the setup script to throw an error/fail if the current working directory contains any spaces.

This was the error I got when I initially ran the setup from my /Git Repo Clones folder:

┌─[mt@archdt] ~ [/home/mt/CODE/Git Repo Clones/rofi]
└─ >> <git:(master 1dabf36✱) > ./setup.sh 

[*] Installing fonts... 
    /home/mt/CODE/Git Repo Clones/rofi (y/n): ^[[Acp: cannot stat '/home/mt/CODE/Git': No such file or directory
cp: cannot stat 'Repo': No such file or directory
cp: cannot stat 'Clones/rofi/fonts/*': No such file or directory
[*] Updating font cache...
 
[*] Creating a backup of your rofi configs... 
[*] Installing rofi configs... 
cp: cannot stat '/home/mt/CODE/Git': No such file or directory
cp: cannot stat 'Repo': No such file or directory
cp: cannot stat 'Clones/rofi/files/*': No such file or directory
[!] Failed to install.

After applying these changes, all dir path characters are preserved throughout the script execution and the installation works as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@m1kethai