Add support for specifying response file location #30
Conversation
Currently, the response goes to a temp location and subsequent inference requests overwrite. This change adds a new input that will allow the user to specify where the response file should be located.
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for specifying a custom response file location so that subsequent inference requests do not overwrite previous responses. Key changes include:
- Updating the token validation to check for empty strings.
- Adding a new input (response-file) and logic to use a custom file path with directory creation if needed.
- Extending tests to cover scenarios for both custom and default response file paths.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main.ts | Added custom response file input and directory creation. |
| action.yml | Defined the new input for specifying the response file. |
| tests/main.test.ts | Updated tests to verify the new response file behavior. |
|
Why should someone be interested in setting the path to the response file? 🤔 What is the use case for this? |
|
I have a workflow where I am doing inference a few times: selecting an area label, a regression label, etc and each time I need a new location. I could (I am now) running the inference, then copying the output, then running again. But, having the copy is messy when I could just run the inference a few times and then collect all the files and post as a single comment. |
|
Looks reasonable enough to me. I can see why you might want to specify the file location if you're plugging this into other workflows that might expect particular files to be in particular places. |
This pull request introduces a new feature for handling custom response file paths in the AI inference action, along with improvements to error handling and test coverage. The changes include updates to the
README.mddocumentation, theaction.ymlfile, the main action logic insrc/main.ts, and the test suite in__tests__/main.test.ts.New Feature: Custom Response File Paths
README.mdexplaining how to use a custom response file path (response-file) in workflows.response-fileinput inaction.ymlto specify the file path where the model's response should be saved.getResponseFilePathhelper function insrc/main.tsto handle custom response file paths, ensuring directories are created if necessary. Updated the main logic to use this function. [1] [2]Improved Error Handling
src/main.tsto gracefully manage bothErrorand non-Errorexceptions, providing clearer feedback in workflow runs. [1] [2]Test Suite Enhancements
__tests__/main.test.tsto verify:Errorand non-Errorexceptions.fs.writeFileSyncandfs.mkdirSyncto support testing file system operations. [1] [2]These changes collectively improve the flexibility, reliability, and testability of the action.