Fix fts build for shared library #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebAssembly#522 did not include the necessary changes to the Makefile for libc_so build.
47b3cc1 to
45991a2
Compare
sbc100
approved these changes
Oct 14, 2024
yamt
approved these changes
Oct 16, 2024
abrown
reviewed
Oct 16, 2024
| make -j4 TARGET_TRIPLE=wasm32-wasip2 WASI_SNAPSHOT=p2 | ||
| make -j4 TARGET_TRIPLE=wasm32-wasi $MAKE_TARGETS | ||
| make -j4 TARGET_TRIPLE=wasm32-wasip1 $MAKE_TARGETS | ||
| make -j4 TARGET_TRIPLE=wasm32-wasip2 WASI_SNAPSHOT=p2 $MAKE_TARGETS |
There was a problem hiding this comment.
Do we need to be passing these $MAKE_TARGETS to the threaded builds a couple of lines below as well?
There was a problem hiding this comment.
It seems like THREAD_MODEL=posix does not support PIC build for now
Line 844 in a05277a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#522 did not include the necessary changes to the Makefile for libc_so build.
Additionally, updated CI to check
libc_sobuild too to avoid future breakage.