Skip to content

Conversation

offl
Copy link
Contributor

@offl offl commented May 28, 2025

Changes proposed:

  • Modernize scripts, small changes (no functionality changed)

Issues addressed:

none

Tests performed:

builds, tested in-game

@offl offl marked this pull request as draft May 29, 2025 14:19
@offl offl marked this pull request as ready for review May 29, 2025 18:00
Copy link
Member

@Shauren Shauren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one doesn't work

Hellmaw is not banished on instance creation (because other npcs load before him, loading order cannot be controller)
Hellmaw is wrong anyway, his banish state should be linked to clearing Cabal Ritualists, not Fel Overseers

@offl
Copy link
Contributor Author

offl commented Jun 10, 2025

Hellmaw is wrong anyway, his banish state should be linked to clearing Cabal Ritualists, not Fel Overseers

Once I change the entry, Hellmaw becomes invisible and appears visible after all ritualists are dead

Hellmaw is not banished on instance creation (because other npcs load before him, loading order cannot be controller)

Didn't encountered. The way he's banished is not correct in first place, on retail he casts Banish spell every 1 sec

@offl offl requested a review from Shauren July 24, 2025 14:49
@Shauren Shauren merged commit 5dcef2b into TrinityCore:3.3.5 Aug 28, 2025
4 of 5 checks passed
@offl offl deleted the ShadowLabyrinth branch August 28, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants