Skip to content

refactor(query-core): improve replaceEqualDeep performance #9604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 2, 2025
Merged

refactor(query-core): improve replaceEqualDeep performance #9604

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e6029db
refactor(query-core): improve replaceEqualDeep performance
Sheraff Aug 31, 2025
5e527f3
try object.prototype that broke eslint in router
Sheraff Aug 31, 2025
1007495
no object flag
Sheraff Aug 31, 2025
25b5bbd
improved version w/ more code
Sheraff Aug 31, 2025
3c69c31
ci: apply automated fixes
autofix-ci[bot] Aug 31, 2025
d225d24
Merge branch 'main' into refactor-query-core-replace-equal-deep-perfo…
TkDodo Sep 1, 2025
91494ca
less code, but still 2x faster
Sheraff Sep 1, 2025
c433b8f
Merge branch 'main' into refactor-query-core-replace-equal-deep-perfo…
TkDodo Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor(query-core): improve replaceEqualDeep performance
  • Loading branch information
@Sheraff
Sheraff committed Aug 31, 2025
commit e6029dba5b32cda46009db493225f193fa5e296f
55 changes: 28 additions & 27 deletions packages/query-core/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,38 +257,39 @@ export function replaceEqualDeep(a: any, b: any): any {
}

const array = isPlainArray(a) && isPlainArray(b)

if (array || (isPlainObject(a) && isPlainObject(b))) {
const aItems = array ? a : Object.keys(a)
const aSize = aItems.length
const bItems = array ? b : Object.keys(b)
const bSize = bItems.length
const copy: any = array ? [] : {}
const aItemsSet = new Set(aItems)

let equalItems = 0

for (let i = 0; i < bSize; i++) {
const key = array ? i : bItems[i]
if (
((!array && aItemsSet.has(key)) || array) &&
a[key] === undefined &&
b[key] === undefined
) {
copy[key] = undefined
const object = !array && isPlainObject(a) && isPlainObject(b)

if (!array && !object) return b

const aItems = array ? a : Object.keys(a)
const aSize = aItems.length
const bItems = array ? b : Object.keys(b)
const bSize = bItems.length
const copy: any = array ? new Array(bSize) : {}
// const aItemsSet = new Set(aItems)

let equalItems = 0

for (let i = 0; i < bSize; i++) {
const key = array ? i : bItems[i]
const aItem = a[key]
if (
(array || a.hasOwnProperty(key)) &&
aItem === undefined &&
b[key] === undefined
) {
copy[key] = undefined
equalItems++
} else {
const value = replaceEqualDeep(aItem, b[key])
copy[key] = value
if (value === aItem && aItem !== undefined) {
equalItems++
} else {
copy[key] = replaceEqualDeep(a[key], b[key])
if (copy[key] === a[key] && a[key] !== undefined) {
equalItems++
}
}
}

return aSize === bSize && equalItems === aSize ? a : copy
}

return b
return aSize === bSize && equalItems === aSize ? a : copy
}

/**
Expand Down
Loading