fix: account for leading slash pattern in wcmatch #1092
Merged
+37
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #1089 by accounting for ignore pattern cases where there's a leading slash present and using
wcmatch, which in gitignore should only match with files and folders in the root directory. Previously this was not accounted for in thewcmatchglob conversion, and would also separately raise aValueErrorexception with a pattern with a leading slash was passed to it.When testing, make sure the internal tools (wcmatch) flag is forced if you have ripgrep on your system. Otherwise this fix is designed to match ripgrep's pattern matching behavior.
Tasks Completed