accept protobuf 6.31.1 #315
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the protobuf version constraint to allow version 6.31.1, addressing a security vulnerability in the inference server codebase.
- Updates protobuf version upper bound from <6.0.0 to <6.31.1
Comments suppressed due to low confidence (1)
setup.py:29
- The version constraint '<6.31.1' is unusual as it excludes version 6.31.1 itself. If the intention is to include version 6.31.1 (as suggested by the PR title), the constraint should be '<=6.31.1' or '<6.31.2'. The current constraint would reject the very version mentioned in the PR title.
'protobuf>=4.21.12,<6.31.1'
|
|
Sorry, I have not looked at this codebase in over a year and was never active with it anyway, and am not qualified to review anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the accepted protobuf versions to resolve security vulnerability in inference server codebase.