UpdateManager.RestartApp fails when EntryAssembly is a dll #1554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen EntryAssembly is a dll.
|
Question: why not check if extension is .dll? If so, call Path.ChangeExtension to exe. That's how I solved the restarting of my .NET Core apps (that now are .dll entry assemblies). But if you have a good reason, I might have to change my method everywhere in my code :-) |
|
Why check the extension and have an if/else instead of using a method that will work for both cases? |
…s-when-EntryAssembly-is-dll
|
Since this has been open for 5 years + without getting merged and it's not building when I update the branch I will l close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1553