Foot snapping fix #1519
Merged
Foot snapping fix #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that isolateYaw is a heavier operation, let's try to only do it once
Eirenliel
approved these changes
Aug 22, 2025
ImUrX
approved these changes
Sep 1, 2025
Stermere
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way foot plant isolates the yaw from the tracker orientation does not work with VRChat IK. It is technically correct for the quaternion, but the euler yaw resulting from it causes snapping. This PR uses a method that does not cause snapping in VRChat.
Please feel free to recommend a better way of fixing this, as this was just the first thing I came up with. One alternative could be using the project function of the quaternion, though that may have its own issues.