LibConfig: Write default read items always back to fill out config files #26170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b65864 to
dacd8c3
Compare
spholz
reviewed
Sep 1, 2025
Comment on lines
+16
to
+19
| write_string_value(ByteString domain, ByteString group, ByteString key, ByteString value, bool notify) => () | ||
| write_i32_value(ByteString domain, ByteString group, ByteString key, i32 value, bool notify) => () | ||
| write_u32_value(ByteString domain, ByteString group, ByteString key, u32 value, bool notify) => () | ||
| write_bool_value(ByteString domain, ByteString group, ByteString key, bool value, bool notify) => () |
There was a problem hiding this comment.
We generally prefer enum classes over bools as function parameters if callers are likely to pass constants (see https://github.com/SerenityOS/serenity/blob/master/Documentation/CodingStyle.md). Though I don't know if this is possible or clean to do with IPC.
There was a problem hiding this comment.
It is possible, but it results in a lot of extra code for just a Yes, No enum. So my preference is to let is a bool, maybe it needs a better name though.
dacd8c3 to
f828738
Compare
LucasChollet
reviewed
Sep 2, 2025
The section_label prop is used as config key. But sometimes it contains spaces. Spaces in config keys are quite ugly and not following the .ini spec I think, so this commit filters them out.
f828738 to
7e2e7e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #26164 to have better multiple user desktop support we have to remove all prefilled config files from anon. But it is a nice feature to view all the available options in a text file and to edit them directly. But currently default config items are not synced to disk, because of the fallback value in code.
This pr update
LibConfigto always write back reads with defaults when the keys don't exist yet. This results in that the complete default config from code is written back to the disk to be viewed and edited. I've changed the ipc interface a bit to suppress notifications of those writes to prevent a read write infinite loop.I also found that
DynamicWidgetContainerused a visual text string as config key which resulted in config keys with spaces so I now filter them out.CC @spholz