Skip to content

Improve contributing experience #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 9, 2023
Merged

Improve contributing experience #3120

merged 3 commits into from
Aug 9, 2023

Conversation

hyperupcall
Copy link
Member

@hyperupcall hyperupcall commented Aug 6, 2023 •
edited
Loading

  • [BREAKING]: Use Node 18 for CI and minimum required engines parameter
    • Nodejs v16 EOL's (security patches) in ~1 month
    • Nodejs v18 is the first version that includes the node:readline/promises module (that this PR uses)
  • Significantly improves organization and instructions in CONTRIBUTING.md
  • README.md Grammar improvements
  • Adds new_schema Grunt task for making it easier to create a new schema
  • Adds linting Grunt tasks
  • Adds a local schema for schema-validation.json
  • Adds npm scripts for Prettier and name the scripts to what's more in line with the npm ecosystem (keep old names for compatibility with existing workflows)

Closes #3107

@github-actions github-actions bot added documentation "**/*.md" folder is updated (auto-generated by labeler action) NodeJS NodeJS files are updated (auto-generated by labeler action) schema-validation.json cli.js gruntfile.js is updated (auto-generated by labeler action) labels Aug 6, 2023
@hyperupcall hyperupcall force-pushed the hyperupcall-various-improvements branch from 7d0029c to 50e94f3 Compare August 6, 2023 03:10
@hyperupcall hyperupcall force-pushed the hyperupcall-various-improvements branch from 50e94f3 to 86f0276 Compare August 6, 2023 03:13
@github-actions github-actions bot added the ci ".github/**/*" folder is updated (auto-generated by labeler action) label Aug 6, 2023
@madskristensen
Copy link
Contributor

This is an excellent improvement. There appear to be merge conflicts, though

@hyperupcall hyperupcall force-pushed the hyperupcall-various-improvements branch from 5b28eca to bdd5d6e Compare August 9, 2023 10:24
@hyperupcall hyperupcall force-pushed the hyperupcall-various-improvements branch from bdd5d6e to 1e6002f Compare August 9, 2023 10:30
@madskristensen madskristensen merged commit 4ddef67 into SchemaStore:master Aug 9, 2023
@madskristensen
Copy link
Contributor

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madskristensen madskristensen Awaiting requested review from madskristensen madskristensen is a code owner

Assignees
No one assigned
Labels
ci ".github/**/*" folder is updated (auto-generated by labeler action) cli.js gruntfile.js is updated (auto-generated by labeler action) documentation "**/*.md" folder is updated (auto-generated by labeler action) NodeJS NodeJS files are updated (auto-generated by labeler action)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve new contributing experience
2 participants
@hyperupcall @madskristensen