Make hydrogen sulfide clouds deal damage #6317
Conversation
…feature (it's a faster approach)
|
I didn't test for long, but I did check that damage is taken without chemosynthesizing proteins and immunity is granted when adding them. The damage taken seems to be reasonable on Normal difficulty, though I wonder if it might be a bit too high on Easy difficulty. (I wasn't able to notice if Easy difficulty changed the damage taken by a noticeable amount, it seemed the same to me) |
|
Tested this for about 20 minutes; very good work, and it's cool to see a relatively simple tweak have a solid effect on gameplay, especially early on. Sulfur has been a pretty under-served metabolism, so this definitely adds a strong characteristic to it which can dramatically influence how we approach it. I think damage was fair; again, it doesn't need to be a gigantic hazard that you're likely to die to, just enough to deter the player. This is simple hazard to avoid just by placing one chemosynthesizing part, which is how it should be for a cloud. We do probably want to attach some sort of reason why a player shouldn't be incentivized to just keep one part in their organism with no consequences for the rest of their game. I think adding some oxygen tolerance debuff would be a good way of doing this. I can do that myself though when I generally tackle balancing metabolism, which is much needed. Balancing the availability of sulfur, how quickly it deteriorates, and environmental events adding sulfur as a hazard event, is also another control we can account for. Not saying the above to make you implement this all by the way. As is, this is a PU I think should be accepted. |
Having the first part cost a significant amount more than consecutive parts would also help out in this area, since it would not be a cheap investment to unlock the first chemosynthesizing part just to provide immunity. |
| @@ -197,6 +197,9 @@ | |||
| "Capacity": 0.25 | |||
| } | |||
| }, | |||
| "FeatureTags": [ | |||
There was a problem hiding this comment.
Shouldn't the eukaryotic part variant also provide the protection?
There was a problem hiding this comment.
I feel like it is wrong to put the code in here like this.
In my opinion a cleaner approach would be to mark hydrogen sulfide compound as always useful, and then something like osmoregulation and healing system could also deal damage if the cell is storing hydrogen sulfide and has no protection against it. To me it feels wrong to put this one special kind of damage type into the base absorption system.
|
Also one thing that might need considering is the AI. Taking in hydrogen sulfide and being damaged should make the AI move in a random roughly forwards direction at full speed for a few seconds. Because if the AI stops in a hydrogen sulfide cloud it will be really strange for the player to see the AI just want to die. Even fully sessile cells I think need to attempt this manoeuvre. |
Brief Description of What This PR Does
Makes hydrogen sulfide clouds deal damage to cells that don't have chemosynthesizing proteins.
This doesn't mean much for sulfur-based metabolism, but sulfur itself is now a bit more unique.
Related Issues
Discussion in this thread
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.