5878 Thermal Vision Hotkey #5988
Conversation
| @@ -258,6 +258,11 @@ public override bool GetCurrentSpeedMode() | |||
| return stage.WorldSimulation.WorldTimeScale > 1; | |||
| } | |||
|
|
|||
| public override bool IsHeatViewAvailable() | |||
There was a problem hiding this comment.
Adding this new method means that this line: bottomLeftBar.HeatViewAvailable = organelles.HeatCollection > 0; in UpdateAbilitiesHotBar should also be updated to use this.
|
|
||
| [Export] | ||
| private TextureButton heatButton = null!; | ||
| public TextureButton HeatButton = null!; |
There was a problem hiding this comment.
This should not be made public as that violates OOP encapsulation principles.
|
We are currently in feature freeze until the next release. |
|
Hey, when checking stuff still going into the next Thrive release I remembered this PR. This won't make it into 0.8.2, but I marked this for 0.8.3 instead. Are you planning on continuing work on this PR? It's fine if you don't have time, and there's still quite a long time until 0.8.3 so there's no rush. |
|
Yeah, I am. Sorry for the delay, I've recently gotten quite busy with school, though I do definitely intend to continue working on it |
|
This PR has been inactive for a while and as such is being marked If this is still being worked on / will probably resume work at |
Brief Description of What This PR Does
Once finished, this will fully implement the hotkey to toggle thermal vision. I'm still very new to programming in C#, so my apologies if I missed anything regarding basic style / best practice. To my knowledge one of the main things missing still are the localization files.
Related Issues
Closes #5878
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.