Skip to content

Add support for 'emoji_added' message type #10284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 3, 2025
Merged

Add support for 'emoji_added' message type #10284

merged 4 commits into from
Sep 3, 2025

Conversation

diceroll123
Copy link
Contributor

@diceroll123 diceroll123 commented Aug 27, 2025 •
edited
Loading

Summary

Adds new message type for added emojis.

The frontend has some added logic that makes it know whether or not the emoji's still there, so the system_content changes to just {user.name} added a new emoji..

Upon adding:

image

After deleting the emoji from the server:

image

the payload does not change

{
    "type": 63,
    "content": "<:really:1410116331352883291>",
    "mentions": [],
    "mention_roles": [],
    "attachments": [],
    "embeds": [],
    "timestamp": "2025-08-27T04:18:52.214000+00:00",
    "edited_timestamp": null,
    "flags": 0,
    "components": [],
    "id": "1410116331876913215",
    "channel_id": "228230433786036224",
    "author": ...
    "pinned": false,
    "mention_everyone": false,
    "tts": false
}

Don't know which makes more sense, guild_emoji_added or guild_emoji_add, up to y'all in the end, but I went with the former.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@pythonmcpi
Copy link
Contributor

Using guild_emoji_add would match with recipient_add, but the overall naming format isn't super consistent in that enum (for example, guild_incident_alert_mode_enabled being past tense).

@diceroll123
Copy link
Contributor Author

Yeah, and audit log action enums are like emoji_create 🤔

@Rapptz
Copy link
Owner

Rapptz commented Aug 27, 2025

The client uses EMOJI_ADDED.

Also here are the other ones missing since I was curious how we skipped almost 20.

  PURCHASE_NOTIFICATION: 44,
  VOICE_HANGOUT_INVITE: 45,
  POLL_RESULT: 46,
  CHANGELOG: 47,
  NITRO_NOTIFICATION: 48,
  CHANNEL_LINKED_TO_LOBBY: 49,
  GIFTING_PROMPT: 50,
  IN_GAME_MESSAGE_NUX: 51,
  GUILD_JOIN_REQUEST_ACCEPT_NOTIFICATION: 52,
  GUILD_JOIN_REQUEST_REJECT_NOTIFICATION: 53,
  GUILD_JOIN_REQUEST_WITHDRAWN_NOTIFICATION: 54,
  HD_STREAMING_UPGRADED: 55,
  CHAT_WALLPAPER_SET: 56,
  CHAT_WALLPAPER_REMOVED: 57,
  REPORT_TO_MOD_DELETED_MESSAGE: 58,
  REPORT_TO_MOD_TIMEOUT_USER: 59,
  REPORT_TO_MOD_KICK_USER: 60,
  REPORT_TO_MOD_BAN_USER: 61,
  REPORT_TO_MOD_CLOSED_REPORT: 62,
  EMOJI_ADDED: 63,

@diceroll123
Copy link
Contributor Author

Could do those here too, but it'd take a bit more effort if we want to get the system_content and such all correct. How many of those are even live?

@Rapptz
Copy link
Owner

Rapptz commented Aug 27, 2025

You don't have to add them, it's purely for my own curiosity.

@diceroll123 diceroll123 changed the title Add support for 'guild_emoji_added' message type Add support for 'emoji_added' message type Aug 27, 2025
@Rapptz
Copy link
Owner

Rapptz commented Aug 27, 2025

I think while you're here you should add the system message flag as well.

@Rapptz Rapptz merged commit bd329b1 into Rapptz:master Sep 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diceroll123 @pythonmcpi @Rapptz