Skip to content

Conversation

shoxxdj
Copy link

@shoxxdj shoxxdj commented Jul 28, 2025

Description

Add an option for exporting in user,password format from nxcdb

export creds combo

Type of change

Insert an "x" inside the brackets for relevant items (do not delete options)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Deprecation of feature or functionality
  • This change requires a documentation update
  • This requires a third party update (such as Impacket, Dploot, lsassy, etc)

Setup guide for the review

Please provide guidance on what setup is needed to test the introduced changes, such as your locally running machine Python version & OS, as well as the target(s) you tested against, including software versions.
In particular:

  • Bug Fix: Please provide a short description on how to trigger the bug, to make the bug reproducable for the reviewer.
  • Added Feature/Enhancement: Please specify what setup is needed in order to test the changes. E.g. is additional software needed? GPO changes required? Specific registry settings that need to be changed?

Screenshots (if appropriate):

Screenshots are always nice to have and can give a visual representation of the change.
If appropriate include before and after screenshot(s) to show which results are to be expected.

Checklist:

Insert an "x" inside the brackets for completed and relevant items (do not delete options)

  • [?] I have ran Ruff against my changes (via poetry: poetry run python -m ruff check . --preview, use --fix to automatically fix what it can) => This create TOML parsing error
  • I have added or updated the tests/e2e_commands.txt file if necessary (new modules or features are required to be added to the e2e tests)
  • New and existing e2e tests pass locally with my changes
  • If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)

elif line[1].lower() == "combo":
csv_header = (
"username",
"password",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the domain ?

@NeffIsBack
Copy link
Member

Thanks for the PR!

Looks to me like currently "simple" and "detailed" outputs exactly the same content. Maybe we should just use simple for that:
image

@NeffIsBack NeffIsBack added enhancement New feature or request database labels Jul 28, 2025
@shoxxdj
Copy link
Author

shoxxdj commented Jul 28, 2025

Hey,

In my case, I need more often to only have user/password without domain.
Simple and detailed output gives too much informations (id, domain,cred type, pillaged_from)
In my case this is too much.

If for you the solution is simple | awk {print $username,$password} feel free to close :D

@termanix
Copy link
Contributor

termanix commented Jul 29, 2025

Thanks for the PR!

Looks to me like currently "simple" and "detailed" outputs exactly the same content. Maybe we should just use simple for that: image

In my PR #810, I editted for simple and detaile part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants