Potential fix for code scanning alert no. 20: Use of externally-controlled format string #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olled format string Fixing string that's fixed Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
|
|
Hello there, thanks for opening your first Pull Request. Someone will review it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/OpenSourceFellows/amplify/security/code-scanning/20
To fix this issue, we should ensure that untrusted user input is never used as a format string in a logging or formatting function. The best and most reliable way to do this in Node.js is to provide a constant format string with
%splaceholders, and pass all untrusted data as arguments to be interpolated. This way, even if the user supplies malicious format specifiers, they will be treated as plain strings and not interpreted. Specifically, inconsole.log(paymentIntent, amount, eventOutcome), we should change this toconsole.log('%s %s %s', paymentIntent, amount, eventOutcome). No new imports or definitions are needed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.