-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
colors(ui): Replaces legacy colors with ui-next colors #5351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dan-rukas
wants to merge
16
commits into
OHIF:master
Choose a base branch
from
dan-rukas:fix/replace-legacy-colors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev canceled.
|
Changed to primary
DateRange.tsx still includes inputfield-main
Uses foreground at different opacities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Updated legacy color variables in the App and ui-next components to use current ui-next colors. Replaced 11 variables with current ui-next color system tokens. Additionally, identified remaining legacy colors with no direct replacements that were manually replaced on a case-by-case evaluation (see details below).
Changes & Results
Color Variable Migration: Legacy to ui-next Mapping
background
bkg-low
foreground
(various)common-bright
highlight
primary-light
input
inputfield-main
input
secondary-light
muted
primary-dark
muted
bkg-med
muted-foreground
aqua-pale
popover
secondary-dark
primary
primary-active
primary
actions-primary
secondary-main
primary-main
common-dark
customblue
Empty cells indicate legacy variables that were manually replaced (details below)
Colors replaced with new colors (not direct replacements)
These legacy variables do not map directly to ui-next color tokens and were evaluated and updated individually based on their use and context.
secondary-main
bg-primary/20
for row hoversDropdown
componentDropdown
componentprimary-main
primary
primary
primary
Button
common-dark
customblue
Tabs
componentStudy list related files that will continue to use legacy colors until Study list redesign
DateRange component (ui-next):
inputfield-main
to match the design of legacy ui components until the Study List is redesignedWorklist.tsx:
ViewportActionBar is no longer in use
secondary-light
and other legacy colorsFurther check across the App
Testing
Some limited testing for specific replacements. Not every replacement was tested since these are direct color replacements (or close to direct).
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment