Revert "Fix bug where width padding was applied twice" #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 14dd68e.
|
I tested sdl_opengl3 and glfw_opengl4, both with anti aliasing (AA) on and off. The left side is now not truncated, but the right side conditionally is. On master the following behavior is not observed, on this branch it is consistent on the two demos tested. Screenshot is taken from glfw_opengl4 with AA off: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through the commits, I found this commit is what was causing some border issues on the button. Mind testing this out?
Coming from #796
This reverts commit 14dd68e.
Looks like there's still something wrong with the window padding, but it does fix the button border.
masterborder-padding