Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds validation checks to the
body-helper
component to catch malformed or invalid physics config values at runtime.Why?
To help prevent subtle bugs and improve error reporting when malformed
.glb
or Spoke-authored scenes define bad physics parameters (e.g.,mass: NaN
,type: null
, etc.).Examples
mass
if it’sNaN
type
if not one ofdynamic
,static
, orkinematic
How to test
Documentation of functionality
No end-user doc updates required. This improves developer-facing behavior.
Limitations
mass
,type
, andgravity
are validated so far.Alternatives considered
Open questions
Additional details or related context
Related to stability issues from malformed input in Spoke or manually edited GLB files.