Skip to content

Remove SIP Casks #41890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2017
Merged

Remove SIP Casks #41890

merged 2 commits into from
Dec 13, 2017

Conversation

commitay
Copy link
Contributor

@commitay commitay commented Dec 13, 2017 •
edited
Loading

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} left no offenses.
  • The commit message includes the cask’s name and version.

Requires SIP to be disabled for > yosemite. https://totalfinder.binaryage.com/sip

Similar case: #38746

@commitay
Copy link
Contributor Author 

Error:
 Cask totalfinder depends on macOS release being one of [10.9, 10.10], but you are running release 10.12.

Error:
 Kernel.exit

@vitorgalvao
Copy link
Contributor

According to the rule to support only the latest two versions, at a certain point it stops making sense we even have these casks.

How about we start removing them and add a rule about not supporting casks that need a disabled SIP to install?

@commitay
Copy link
Contributor Author

How about we start removing them and add a rule about not supporting casks that need a disabled SIP to install?

Yes, makes sense. I'll update this to remove them and add SIP to rejected_casks.

@commitay commitay changed the title Update totalfinder to 1.9.3 Remove SIP Casks Dec 13, 2017
@commitay commitay merged commit d1cfd12 into Homebrew:master Dec 13, 2017
@commitay commitay deleted the cask_repair_update-totalfinder branch December 13, 2017 22:43
@commitay commitay mentioned this pull request Dec 13, 2017
Merged
@sscotth
Copy link
Contributor

sscotth commented Dec 13, 2017

Tap for posterity: https://github.com/sscotth/homebrew-sip

@commitay commitay mentioned this pull request Dec 13, 2017
Merged
@wickles
Copy link
Contributor

wickles commented Apr 18, 2018

@sscotth I take it you do not plan to maintain that tap?

@sscotth
Copy link
Contributor

sscotth commented Apr 18, 2018 •
edited
Loading

@wickles Thanks for the ping. I can add the #41971 casks if that's what you are looking for. I didn't know they existed. If there's an update or another cask that I should know about it, post an issue or PR on the repo.

Edit: Done

@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@vitorgalvao vitorgalvao vitorgalvao approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@commitay @vitorgalvao @sscotth @wickles