Skip to content

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Feb 27, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • Fixes brew audit will detect the license for the main branch instead of the release #16711.
  • Some repositories occasionally change their licenses. For example they release a version of the software with one license and then decide to change the license later.
  • Now that ?ref= is a parameter to the GitHub Repositories License API (the docs updates will process soon - I shipped the actual feature though), we can use that in the license audit to check if the license of the specific release matches the one declared in the formula.

Having removed the formula from the audit exceptions file, here's the previous behaviour:

❯ brew audit --online --git --skip-style manticoresearch
manticoresearch
  * Formula license ["GPL-2.0-only"] does not match GitHub license ["GPL-3.0"].
Error: 1 problem in 1 formula detected.

And now:

❯ brew audit --online --git --skip-style manticoresearch

- Some repositories occasionally change their licenses. For example they
  release a version of the software with one license and then decide to change
  the license later.
- Now that `?ref=` is a parameter to the GitHub Repositories License API,
  we can use that in the license audit to check if the license of the specific
  release matches the one declared in the formula.
@issyl0 issyl0 marked this pull request as draft February 27, 2024 17:08
@issyl0 issyl0 marked this pull request as ready for review February 27, 2024 17:36
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as usual, thanks @issyl0!

@MikeMcQuaid MikeMcQuaid merged commit 0afede3 into master Feb 27, 2024
@MikeMcQuaid MikeMcQuaid deleted the look-for-licenses-not-always-on-the-default-branch branch February 27, 2024 18:30
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew audit will detect the license for the main branch instead of the release
2 participants