-
Notifications
You must be signed in to change notification settings - Fork 1.5k
contrib: update to FFmpeg 8.0 #7201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Given the amount of patches we always need to adapt with new ffmpeg updates, wouldn't it be good to get them (or at least some/most) applied upstream? I know this is not easy with ffmpeg, but maybe it is a bit easier now that they accept merge requests via forgejo. |
Yup, some definitely could be upstreamed, like the QSV ones, and the mov ones, and the PGS sub one. Help is welcomed :) But updating the patches is usually a 15 minutes work, the long part is hunting down the various regressions or API changes. |
I could definitely help with opening merge requests for those patches on forgejo. But they might ask for changes to this patches, and then I might be lost. And I don't know how to bring over the original author of those patches into the forgejo MR. |
@antonkesy there seems to be something going wrong with QSV when the --align-av option is enabled, here's a log: Activity log
It's related to the generation of black frames in sync.c, it looks like the qsv_vpp filter doesn't like them now, but the error is quite unhelpful. |
Actually it looks like the black frames generation plus qsv_vpp combo is broken in the current master branch too, so it's not a new regression and won't block this PR. Anyway, if you have a moment to take a look at this issue, because I don't really know what to do. |
Sure, I'll investigate. |
Preliminary work to update FFmpeg to version 8.0
Tested on: