Skip to content

Update ShellView.xaml #7145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update ShellView.xaml #7145

wants to merge 2 commits into from

Conversation

pgg3
Copy link

@pgg3 pgg3 commented Aug 13, 2025 •
edited
Loading

Rename those two views to avoid ambiguity

Before Posting:

  • Create an issue describing the change. If an issue already exists, please use this.
  • Discuss the issue with the HandBrake team to ensure that the idea has been accepted. (An open enhancement request does not equal acceptance). This will avoid any time wasted on features that are outside the project scope!

Description of Change:

Rename those two views to avoid ambiguity

Tested on:

  • Windows 10+ (via MinGW)
  • macOS 10.13+
  • Ubuntu Linux

Screenshots (If relevant):

Log file output (If relevant):

pgg3 added 2 commits August 13, 2025 18:33
@pgg3
Update ShellView.xaml
adf7d34 
Rename those two views to avoid ambiguity
@pgg3
Update ShellViewModel.cs
df8ce6a 
Remove WindowTitle attribute. Since it is never used.
The real used one is MainViewModel.WindowTitle.
sr55
sr55 reviewed Aug 19, 2025
View reviewed changes
win/CS/HandBrakeWPF/ViewModels/ShellViewModel.cs
/// <summary>
/// Gets WindowTitle.
/// </summary>
public string WindowTitle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used. You shouldn't remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sr55 sr55 sr55 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgg3 @sr55