Propagate Api Key UID when it is returned by the service controller. #892
Conversation
| credential_id += info.api_key; | ||
| credential_id = credential_id | ||
| + (info.check_response_info.api_key_uid.empty() ? info.api_key | ||
| : info.check_response_info.api_key_uid); |
There was a problem hiding this comment.
NIT: define credential_id as constchar above and use absl::StrCat to concat string.
There was a problem hiding this comment.
I mean the constexpr char like in l348
| @@ -176,6 +176,8 @@ struct CheckResponseInfo { | |||
| // The trust level of the API Key that was checked. | |||
| api_key::ApiKeyState api_key_state; | |||
|
|
|||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Elliot-xq, TAOXUY The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
@Elliot-xq: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Propagates the API key UID if it is returned in the service controller CheckResponse.
If it is not returned by the CheckResponse, we will still use the api_key as it is.