Prevent accidentally navigating away from an in progress game #1974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Neat stuff, always dig small touches like this that improve quality of life somehow, as I'm a big fan or https://littlebigdetails.com :-) |
CyberBishop
pushed a commit
to CyberBishop/AncientBeast
that referenced
this pull request
Apr 20, 2023
…on-on-game Prevent accidentally navigating away from an in progress game
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds checks to
window.beforeunloadto prevent accidentally navigating away from an in-progress game.This has bitten me a few times while testing, when I've accidentally hit one of the back/forward side buttons on my mouse. Very annoying!
Refreshing page:
Closing tab:
Allow
webpack-dev-serverlive reload to bypass the check to preserve dev feedback loop: