fix: dash player tabs broken #1349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job! @russon77 👍 |
ktiedt
reviewed
Jun 20, 2018
| @@ -621,6 +621,7 @@ export class UI { | |||
| */ | |||
| showCreature(creatureType, player) { | |||
| let game = this.game; | |||
| let that = this; | |||
There was a problem hiding this comment.
If we must use this horrible practice. Please use self not that
ktiedt
reviewed
Jun 20, 2018
| if (game.freezedInput) { | ||
| return; | ||
| } | ||
|
|
||
| this.showCreature('--', $j(this).attr('player') - 0); | ||
| that.showCreature('--', $j(this).attr('player') - 0); |
There was a problem hiding this comment.
would e.target for the $j() call not also resolve this without the that reference?
CyberBishop
pushed a commit
to CyberBishop/AncientBeast
that referenced
this pull request
Apr 20, 2023
dash player tabs fixed, closes FreezingMoon#1324
CyberBishop
pushed a commit
to CyberBishop/AncientBeast
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1324
the problem was that arrow functions in javascript absorb the
thisof the parent scope, while jquery likes to bindthisof event handlers to the given element. so changing the arrow function to a normal function did the trick