Skip to content

Conversation

rjordanbarnes
Copy link
Contributor

For #1223

@DreadKnight
Copy link
Member

DreadKnight commented Oct 4, 2017

Hmm, if I click on a unit ability twice or click on the icon, I still don't see the cancel text hint. Good cases are when clicking outside the active ability's range or when using the mouse wheel scroll to toggle in between.

You basically fixed the initial issue, though I commented on the issue a while after wanting to make it more generic, I could merge this PR and make another issue, let me know how far you want to go with this one. Switching between one ability to another one shouldn't really show a cancel text hint, too cluttered like that.

@rjordanbarnes
Copy link
Contributor Author

That's strange. Unless I'm misunderstanding, my local build is behaving as you describe you want it to. For example, if I spawn a Scavenger, move it in front of an enemy, and then click its Slicing Pounce ability twice, I receive the Canceled text hint. If I scroll through the abilities with my mousewheel I don't receive the hint unless it scrolls to a passive ability.

@DreadKnight
Copy link
Member

You're right, it's perfect, well done! I was testing the wrong thing and had some caching issues as well apparently, I'm a bit under the weather today, so I'm not getting things done right that easily overall xD

@DreadKnight DreadKnight merged commit abe62f9 into FreezingMoon:master Oct 4, 2017
@rjordanbarnes rjordanbarnes deleted the cancel-context branch October 4, 2017 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants