fixes spa Goggles toggle bug #1191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DreadKnight
reviewed
Apr 28, 2017
src/abilities/Swine Thug.js
Outdated
| if (hex.trap) { | ||
| if (hex.trap.type == "mud-bath") { | ||
| if (hex.trap.type == "mud-bath") { | ||
| G.UI.abilitiesButtons[0].changeState('noclick') |
There was a problem hiding this comment.
Is this lacking a semicolon on purpose?
|
It's not necessary. It can be added. |
|
@thamaranth Seen videos about coders not using them in JS, but there are some scenarios where you can bump into issues. Please add, as a part of coding consistency. |
|
while it is true that trailing semi-colons are not necessary, even Brendan Eich, who created JS and ASI (automatic semicolon insertion) regrets that decision to a degree ;) https://brendaneich.com/2012/04/the-infernal-semicolon/ Always best to include them, especially in projects that concatenate files. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1083