winpr: move ndr routines from rdpear to winpr #11588
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
clang-tidy review says "All clean, LGTM! 👍" |
winpr/include/winpr/ndr.h
Outdated
| extern WINPR_API const NdrMessageDescr ndr_##LOWER##_descr_s; \ | ||
| WINPR_API NdrMessageType ndr_##LOWER##_descr(void) | ||
|
|
||
| #define NDR_ARRAY_OF_TYPE_DECL(TYPE, UPPERTYPE) \ |
There was a problem hiding this comment.
maybe also remove the macros from public headers.
There was a problem hiding this comment.
The macros are used in this header. And usually when you want to declare a new type you'll want to use them.
There was a problem hiding this comment.
Yes, but in public headers it is better not to expose stuff that should not be used outside.
The declarations can just be inserted directly (not that many anyway)
5f6693d to
6949f16
Compare
|
Refer to this link for build results (access rights to CI server needed): |
6949f16 to
d8c3078
Compare
|
Refer to this link for build results (access rights to CI server needed): |
d8c3078 to
e27eda3
Compare
winpr/include/winpr/ndr.h
Outdated
| { | ||
| #endif | ||
|
|
||
| typedef struct NdrContext_s NdrContext; |
There was a problem hiding this comment.
prefixing should also be done for types/macros/... (same issue as with functions, we want to avoid clashing with other implementations)
|
Refer to this link for build results (access rights to CI server needed): |
e27eda3 to
8d2c143
Compare
|
I've done the renamings but I've seen things I'd like to fix for a public API. |
|
Refer to this link for build results (access rights to CI server needed): |
This patch makes public NDR routines and split the NdrContext to a NDR encoder and a NDR decoder. All the related functions are modified accordingly.
8d2c143 to
927825a
Compare
No description provided.