Add support to move visject socket connections #3552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as ready for review because it's fundamentally working now. Just need to eliminate that one edge case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the ability to move all connections to a box to a different box (see video).
For that I refactored visject to allow for multiple
IConnectionInstigators.This pr also fixes doing a connection with a box that already has a connection. Before, the old connection would be cleared and no new one would be created. Now this works as expected.
I am unsure about how I get if the user is pressing the Ctrl key, idk if I chose the right way (see Box.cs L 553 in changed files).
That edgecase with the bool and node has been fixed :)
ConnectionMove.mp4
TODO