Skip to content

Conversation

lchastel
Copy link
Contributor

Description

Fix #12955
Set default value of postgresql.postgresServer to 127.0.0.1 so helm install won't failed if it's not defined.
Move the comment on postgresServer at the beginning of postgresql item, to ease the usage of external instance.

Test results

helm template . --values myvalues.yaml --show-only templates/configmap.yaml
---
# Source: defectdojo/templates/configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: defectdojo
  labels:
    app.kubernetes.io/name: defectdojo
    app.kubernetes.io/instance: defectdojo
    app.kubernetes.io/managed-by: Helm
    helm.sh/chart: defectdojo-1.6.203-dev
data:
.... 
  DD_DATABASE_HOST: 127.0.0.1
.... 

Documentation

N/A

Checklist

This checklist is for your information.

  • Make sure to rebase your PR against the very latest dev.
  • Features/Changes should be submitted against the dev.
  • Bugfixes should be submitted against the bugfix branch.
  • Give a meaningful name to your PR, as it may end up being used in the release notes.
  • Your code is flake8 compliant.
  • Your code is python 3.11 compliant.
  • If this is a new feature and not a bug fix, you've included the proper documentation in the docs at https://github.com/DefectDojo/django-DefectDojo/tree/dev/docs as part of this PR.
  • Model changes must include the necessary migrations in the dojo/db_migrations folder.
  • Add applicable tests to the unit tests.
  • Add the proper label to categorize your PR.

Copy link

dryrunsecurity bot commented Aug 11, 2025

DryRun Security

No vulnerability summary was generated for this pull request.


All finding details can be found in the DryRun Security Dashboard.

@lchastel lchastel changed the base branch from master to dev August 11, 2025 17:16
@lchastel lchastel marked this pull request as ready for review August 11, 2025 17:18
@mtesauro mtesauro requested review from rossops and kiblik August 12, 2025 17:02
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit 23704b0 into DefectDojo:dev Aug 14, 2025
86 of 87 checks passed
@valentijnscholten valentijnscholten added this to the 2.50.0 milestone Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm chart not rendering when cloudsql is enabled and postgresql is not.
6 participants