Skip to content

Conversation

yunlingz
Copy link
Contributor

@yunlingz yunlingz commented Apr 3, 2025

💻 Change Type

  • feat
  • fix
  • refactor
  • perf
  • style
  • test
  • docs
  • ci
  • chore
  • build

🔀 Description of Change

By default, the o1/o3 models do not attempt to produce output with markdown formatting, resulting in a poor user experience due to responses being unformatted and hard to read.

This PR manually adds the developer message "Formatting re-enabled" to encourage the inclusion of markdown in model responses.

The developer message "Formatting re-enabled" is the official suggested way, references: https://platform.openai.com/docs/guides/reasoning-best-practices and https://learn.microsoft.com/en-us/azure/ai-services/openai/how-to/reasoning?tabs=python-secure#markdown-output.

image

Test results:

Before (response unformatted) After (naturally markdown formatting)
Screenshot 2025-04-03 222136 Screenshot 2025-04-03 222827

📝 Additional Information

Summary by CodeRabbit

  • New Features
    • Introduced a new "developer" role in chat interactions, enhancing the messaging capabilities.
    • Improved markdown formatting in chat responses, providing better clarity and ease of reading for users.

Copy link

vercel bot commented Apr 3, 2025

@yunlingz is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Apr 3, 2025

Walkthrough

This update extends the RequestPayload interface by adding a new "developer" role to the role property, updating its allowed values to include "developer", "system", "user", and "assistant". Additionally, in the chat method of the ChatGPTApi class within app/client/platforms/openai.ts, a new message with the "developer" role and content "Formatting re-enabled" is inserted at the beginning of the messages array when the model is either "o1" or "o3". The interface structure remains intact aside from this new role.

Changes

File Change Summary
app/.../openai.ts - Updated RequestPayload interface to include "developer" in the role union type.
- Modified chat method to prepend a developer message for models "o1" and "o3".

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant C as ChatGPTApi
    participant O as OpenAI Platform

    U->>C: Call chat() with messages
    alt Model is "o1" or "o3"
        C->>C: Prepend developer message ("Formatting re-enabled")
    end
    C->>O: Send updated RequestPayload
    O-->>C: Return response
    C-->>U: Return response
Loading

Poem

Hop along through lines of code,
Where roles expand and paths reload,
"Developer" hops in with a twist so keen,
Formatting magic in every scene,
With each new change, the bytes all gleam!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f7c747c and c261ebc.

📒 Files selected for processing (1)
  • app/client/platforms/openai.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/client/platforms/openai.ts

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yunlingz yunlingz changed the title Encourage markdown inclusion in model responses for o1/o3 Fix: Encourage markdown inclusion in model responses for o1/o3 Apr 6, 2025
@Leizhenpeng Leizhenpeng merged commit c30ddfb into ChatGPTNextWeb:main Jun 12, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants