Skip to content

Conversation

ExtReMLapin
Copy link
Contributor

What does this PR do?

When using env variable arcadedb.server.rootPassword you can now update root password on each boot and not just on first boot to prevent stdin "listening"

Motivation

What inspired you to submit this pull request?

Related issues

#2058

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@ExtReMLapin ExtReMLapin marked this pull request as ready for review March 12, 2025 15:47
@ExtReMLapin ExtReMLapin changed the title Allow root password to be updated using arcadedb.server.rootPassword Allow root password to be updated using arcadedb.server.rootPassword and arcadedb.server.rootPasswordPath Mar 12, 2025
@ExtReMLapin
Copy link
Contributor Author

Not sure if it's worth merging as there was an alternative solution proposed there : #2058 (comment)

@gramian
Copy link
Collaborator

gramian commented Mar 12, 2025

This would allow to overwrite the root password not only for its intended purpose when used inside a container but also on bare metal installs. I am not sure if this may have security implications (?), but none come to mind directly.

@ExtReMLapin
Copy link
Contributor Author

I'm a little confused about the Codacy warning, feel free to update the PR to fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants