Skip to content

fix: avoid triggering global logging config #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2020
Merged

fix: avoid triggering global logging config #333

merged 2 commits into from
Dec 1, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 1, 2020

Closes #332

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Dec 1, 2020
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2020
@tseaver tseaver requested a review from frankyn December 1, 2020 21:02
@andrewsg
Copy link
Contributor

andrewsg commented Dec 1, 2020

Thanks!

@andrewsg andrewsg merged commit 602108a into master Dec 1, 2020
@andrewsg andrewsg deleted the 332-fix-logging branch December 1, 2020 23:52
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
fix: avoid triggering global logging config (googleapis#333)
4f31f99 
Closes googleapis#332
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
fix: avoid triggering global logging config (googleapis#333)
75dbd94 
Closes googleapis#332
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

@tswast tswast Awaiting requested review from tswast

@crwilcox crwilcox Awaiting requested review from crwilcox

@busunkim96 busunkim96 Awaiting requested review from busunkim96

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logging.info() triggers basicConfig()
3 participants
@tseaver @andrewsg @yoshi-kokoro