Skip to content

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 15, 2020

Also, re-document classes lost in async split.

Closes #277.

@tseaver tseaver requested review from crwilcox and a team December 15, 2020 20:32
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Dec 15, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2020
Copy link
Contributor

@craiglabenz craiglabenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit 29c6374 into master Feb 2, 2021
@tseaver tseaver deleted the 277-docs-fix-document-set-docstring branch February 2, 2021 20:34
tseaver added a commit to MaxxleLLC/python-firestore that referenced this pull request Feb 3, 2021
crwilcox added a commit that referenced this pull request Feb 5, 2021
* docs: add documentation for documentsnapshot class

* chore: drop superseded docs fix

See PR #278.

Co-authored-by: Tres Seaver <tseaver@palladion.com>
Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Document.set docstring mentions option argument, does not describe merge
3 participants