Skip to content

feat(firestore): add client_options to base class #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2020
Merged

feat(firestore): add client_options to base class #148

merged 2 commits into from
Aug 13, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #124 🦕

@HemangChothani HemangChothani requested a review from tseaver August 10, 2020 09:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2020
@crwilcox
Copy link
Contributor

LGTM. can you also open a similar pr against v2?

busunkim96
busunkim96 approved these changes Aug 12, 2020
View reviewed changes
@tseaver @busunkim96
chore: bump g-c-c to 1.4.1
632225e 
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@crwilcox crwilcox merged commit 91d6580 into googleapis:master Aug 13, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 20, 2020

PR #150 ported this work to the v2-staging branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver Awaiting requested review from tseaver

2 more reviewers

@crwilcox crwilcox crwilcox approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement new client options
4 participants
@HemangChothani @crwilcox @tseaver @busunkim96