[12.x] Use array_first and array_last polyfills (#56703)

KIKOmanasijev · kikomanasijev · web-flow · commit c6e9e71a1885 · 2025-08-21T09:37:28.000-05:00
* Use array_first and array_last polyfills

* trigger tests

* fix tests

---------

Co-authored-by: kikomanasijev &lt;hristijan.manasijev@nteams.com&gt;
diff --git a/composer.json b/composer.json
@@ -53,7 +53,7 @@
         "symfony/mime": "^7.2.0",
         "symfony/polyfill-php83": "^1.31",
         "symfony/polyfill-php84": "^1.31",
-        "symfony/polyfill-php85": "^1.31",
+        "symfony/polyfill-php85": "^1.33",
         "symfony/process": "^7.2.0",
         "symfony/routing": "^7.2.0",
         "symfony/uid": "^7.2.0",
diff --git a/src/Illuminate/Collections/Arr.php b/src/Illuminate/Collections/Arr.php
@@ -256,6 +256,10 @@ public static function first($array, ?callable $callback = null, $default = null
                 return value($default);
             }
 
+            if (is_array($array)) {
+                return array_first($array);
+            }
+
             foreach ($array as $item) {
                 return $item;
             }
@@ -283,7 +287,7 @@ public static function first($array, ?callable $callback = null, $default = null
     public static function last($array, ?callable $callback = null, $default = null)
     {
         if (is_null($callback)) {
-            return empty($array) ? value($default) : end($array);
+            return empty($array) ? value($default) : array_last($array);
         }
 
         return static::first(array_reverse($array, true), $callback, $default);
diff --git a/src/Illuminate/Testing/Constraints/HasInDatabase.php b/src/Illuminate/Testing/Constraints/HasInDatabase.php
@@ -34,6 +34,7 @@ class HasInDatabase extends Constraint
      *
      * @param  \Illuminate\Database\Connection  $database
      * @param  array<string, mixed>  $data
+     * @return void
      */
     public function __construct(Connection $database, array $data)
     {
@@ -81,7 +82,7 @@ protected function getAdditionalInfo($table)
 
         $similarResults = $query->where(
             array_key_first($this->data),
-            $this->data[array_key_first($this->data)]
+            array_first($this->data),
         )->select(array_keys($this->data))->limit($this->show)->get();
 
         if ($similarResults->isNotEmpty()) {

Original file line number	Diff line number	Diff line change
`@@ -256,6 +256,10 @@ public static function first($array, ?callable $callback = null, $default = null`
`256`	`256`	`return value($default);`
`257`	`257`	`}`
`258`	`258`
	`259`	`+ if (is_array($array)) {`
	`260`	`+ return array_first($array);`
	`261`	`+ }`
	`262`	`+`
`259`	`263`	`foreach ($array as $item) {`
`260`	`264`	`return $item;`
`261`	`265`	`}`
`@@ -283,7 +287,7 @@ public static function first($array, ?callable $callback = null, $default = null`
`283`	`287`	`public static function last($array, ?callable $callback = null, $default = null)`
`284`	`288`	`{`
`285`	`289`	`if (is_null($callback)) {`
`286`		`- return empty($array) ? value($default) : end($array);`
	`290`	`+ return empty($array) ? value($default) : array_last($array);`
`287`	`291`	`}`
`288`	`292`
`289`	`293`	`return static::first(array_reverse($array, true), $callback, $default);`
Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ class HasInDatabase extends Constraint`
`34`	`34`	`*`
`35`	`35`	`* @param \Illuminate\Database\Connection $database`
`36`	`36`	`* @param array<string, mixed> $data`
	`37`	`+ * @return void`
`37`	`38`	`*/`
`38`	`39`	`public function __construct(Connection $database, array $data)`
`39`	`40`	`{`
`@@ -81,7 +82,7 @@ protected function getAdditionalInfo($table)`
`81`	`82`
`82`	`83`	`$similarResults = $query->where(`
`83`	`84`	`array_key_first($this->data),`
`84`		`- $this->data[array_key_first($this->data)]`
	`85`	`+ array_first($this->data),`
`85`	`86`	`)->select(array_keys($this->data))->limit($this->show)->get();`
`86`	`87`
`87`	`88`	`if ($similarResults->isNotEmpty()) {`