-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
spec:editorialMinor change in the specification (markup, typo, informative text; class 1 or 2)Minor change in the specification (markup, typo, informative text; class 1 or 2)
Description
While working on PR #245, I noticed that the translation algorithm in Section 18.3.4.1 Grouping and Aggregation has a number of minor issues that should be fixed:
- The algorithm introduces variable
A
as "the empty sequence" and, later, saysAi := Aggregation(...)
in a number of places. It is not clear what this is supposed to mean. I am guessing it is meant to extend the length ofA
such that it has an i-th position and then assign the givenAggregation(...)
expression to this position; essentially, appending theAggregation(...)
expression to the end ofA
. A more readable way to write this is to do exactly as done for adding elements toE
within the same algorithm, namely:
A := A append Aggregation(...)
- At the end, the algorithm says
A := Ai, ..., Ai-1
I assume thatAi
here is meant to beA1
. Also, after applying my proposal of the previous point, this whole line can be removed completely. - The algorithm mentions some symbol called
aggi
without saying anything about it. It took me a long time to figure out that this is meant to be a new (fresh) variable for every value ofi
during the algorithm. This should be made more explicit in the algorithm.
TallTed
Metadata
Metadata
Assignees
Labels
spec:editorialMinor change in the specification (markup, typo, informative text; class 1 or 2)Minor change in the specification (markup, typo, informative text; class 1 or 2)