Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vagrant-libvirt/vagrant-libvirt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.12.1
Choose a base ref
...
head repository: vagrant-libvirt/vagrant-libvirt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.12.2
Choose a head ref
  • 2 commits
  • 18 files changed
  • 2 contributors

Commits on Jun 20, 2023

  1. Handle nic model type updating during start (#1747) 

    Start domain added some support to update the nic model type if it
changed to avoid needing to completely destroy and recreate the domain.
Additionally support for setting the management network nic model type
was added, however the default value did not correctly reflect expected.

This updates `management_network_model_type` to default to
`nic_model_type`, which in turn defaults to `virtio`. This has now been
moved from the create network interfaces action into the config object
to allow chained resolving. This should ensure that setting
`nic_model_type` will correctly cause all networks to use the model
unless explicitly specified to use a different model.

Additionally the start domain action for updating the interfaces has
been modified to loop over all interfaces and all configured adapters in
the order they should have been added. This allows for checking whether
the model type needs to be updated based on the
`management_network_model_type` config option for the first network,
assuming the management network has been attached, and otherwise to fall
back to the default from `nic_model_type` for all other interfaces.

Finally ensure the iommu attribute is removed from the nic driver if
the model type is switched to anything other virtio to avoid issues with
attempting to enable invalid settings.

Fixes: #1743
    @electrofelix
    electrofelix authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    889b13d View commit details
    Browse the repository at this point in the history

  2. Bump JamesIves/github-pages-deploy-action from 4.4.1 to 4.4.2 (#1745)

    @dependabot
    dependabot[bot] authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    448ed69 View commit details
    Browse the repository at this point in the history
Loading